Skip to content

feat(dashmate): exit status with 2 if it's not running#896

Merged
shumkov merged 1 commit into
v0.24-devfrom
fix/status-should-report
Apr 7, 2023
Merged

feat(dashmate): exit status with 2 if it's not running#896
shumkov merged 1 commit into
v0.24-devfrom
fix/status-should-report

Conversation

@shumkov
Copy link
Copy Markdown
Collaborator

@shumkov shumkov commented Apr 7, 2023

Issue being fixed or feature implemented

The status command returns exit code 1 if nodes are not running and other errors are occurring. It prevents to handle properly restart/start logic in the deployment tool

What was done?

  • Exit with code 2 if sevices are not running

How Has This Been Tested?

None

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v0.24.0 milestone Apr 7, 2023
@shumkov shumkov requested a review from antouhou as a code owner April 7, 2023 19:02
Copy link
Copy Markdown
Collaborator

@pshenmic pshenmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@shumkov shumkov merged commit adb7595 into v0.24-dev Apr 7, 2023
@shumkov shumkov deleted the fix/status-should-report branch April 7, 2023 19:05
@markin-io markin-io mentioned this pull request Apr 26, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants