Skip to content

fix(dpp): various fixes in DPP and system contracts#907

Merged
markin-io merged 6 commits into
v0.24-devfrom
feat-rs-dpp-24
Apr 12, 2023
Merged

fix(dpp): various fixes in DPP and system contracts#907
markin-io merged 6 commits into
v0.24-devfrom
feat-rs-dpp-24

Conversation

@antouhou
Copy link
Copy Markdown
Contributor

@antouhou antouhou commented Apr 11, 2023

Issue being fixed or feature implemented

Variety of fixes and improvements appeared during the integraiton of wasm-dpp into JS-Drive and SDK

What was done?

rs-dpp

  • Fixed bug with missing document_types when setting document schema
  • Changed legacy store_data_contract to update_data_contract
  • Fixed bug with unhandled "replace" action for masternode reward shares data trigger
  • Simplified check for SML entries in masternode reward shares data trigger
  • Fixed bug with missing update for updatedAt when document is updated
  • Fixed minor bugs with identitu update and data contract update serialization
  • Workarounded bug with negative credits calculation
  • Fixed bugs with ST pre-validation cleanup in state transition factory
  • Changed url to uri in JSON schemas

wasm-dpp

  • Fixed bug with fetching of GIT dependencies during the building procedure
  • Fixed bug with invoking of Buffer()
  • Added wasm-logger to retranslate logs from rs-dpp
  • Allow optional metadata in setMetadata functions
  • Fixed multiple bugs with the move of JS objects into Rust context (null pointer passed to Rust)
  • Added missing getExecutionContext
  • Reworked set/get_<date>_at setters and getters to return and accept js Dates instead of u64
  • Exposed JS constructors for some errors
  • Added function to generate one time ECDSA private key
  • Reworked Operations bindings to accept and return JS objects instead of instances or enums (OperationWasm, RefundWasm)

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@antouhou antouhou requested a review from shumkov as a code owner April 11, 2023 11:42
Comment thread packages/rs-dpp/src/data_trigger/get_data_triggers_factory.rs Outdated
Copy link
Copy Markdown
Contributor Author

@antouhou antouhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Self-thumbs-up 👍

markin-io
markin-io previously approved these changes Apr 11, 2023
Copy link
Copy Markdown
Collaborator

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov changed the title feat(dpp): move all dpp changes from integration branch fix(dpp): various fixes in DPP and system contracts Apr 12, 2023
@markin-io markin-io merged commit 6e46bf0 into v0.24-dev Apr 12, 2023
@markin-io markin-io deleted the feat-rs-dpp-24 branch April 12, 2023 10:34
@thephez thephez added this to the v0.24.0 milestone Apr 24, 2023
markin-io pushed a commit that referenced this pull request Apr 26, 2023
Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
@markin-io markin-io mentioned this pull request Apr 26, 2023
5 tasks
markin-io pushed a commit that referenced this pull request Apr 26, 2023
Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants