You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Part of the config builder update. Since the config is gonna become immutable once is built to ensure is valid while it is alive this method must be removed
Summary by CodeRabbit
Breaking Changes
Removed mempool tracking functionality from the API.
Documentation
Updated API documentation to reflect removal of mempool operations. Total available functions reduced from 67 to 66.
✏️ Tip: You can customize this high-level summary in your review settings.
This change removes mempool tracking initialization functionality from the public API and implementation layers. The dash_spv_ffi_client_enable_mempool_tracking function, associated enum, and related methods are deleted from documentation, headers, FFI implementation, core client code, and tests.
Changes
Cohort / File(s)
Summary
Documentation dash-spv-ffi/FFI_API.md
Removed Mempool Operations section and function entry; updated Table of Contents; function count decreased from 67 to 66
FFI Header dash-spv-ffi/include/dash_spv_ffi.h
Removed public function dash_spv_ffi_client_enable_mempool_tracking; relocated FFIMempoolStrategy enum (moved after DashSpvValidationMode)
FFI Implementation dash-spv-ffi/src/client.rs
Removed FFI function dash_spv_ffi_client_enable_mempool_tracking and its error handling logic; removed FFIMempoolStrategy from public imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the config builder update. Since the config is gonna become immutable once is built to ensure is valid while it is alive this method must be removed
Summary by CodeRabbit
Breaking Changes
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.