chore: cleanup unused dependencies

[xdustinface]

Summary by CodeRabbit

• Chores
  • Streamlined dependencies across multiple modules by removing unused packages, improving build efficiency and codebase maintainability.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c5577e5b-e812-40b4-8965-6b5d7d78cec6

📥 Commits

Reviewing files that changed from the base of the PR and between 88e8a9a and 8aeba02.

📒 Files selected for processing (3)

• dash-spv-ffi/Cargo.toml
• dash-spv/Cargo.toml
• hashes/Cargo.toml

💤 Files with no reviewable changes (3)

• hashes/Cargo.toml
• dash-spv/Cargo.toml
• dash-spv-ffi/Cargo.toml

---

📝 Walkthrough

Walkthrough

This PR removes unused dependencies from three Cargo.toml files across different packages: dash-spv-ffi, dash-spv, and hashes. The changes eliminate a total of 15 dependency declarations without altering any public API signatures or logic.

Changes

Cohort / File(s)	Summary
Dependency Cleanup dash-spv-ffi/Cargo.toml, dash-spv/Cargo.toml, hashes/Cargo.toml	Removed unused dependencies: dash-spv-ffi removes 7 dependencies (libc, once_cell, serde, serde_json, log, env_logger, rand); dash-spv removes 4 dependencies (blsful git dependency, anyhow, bincode, indexmap); hashes removes secp256k1 dependency with features.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Hopping through the cargo file so clean,
Swept away the unused, so pristine,
Dependencies gone, no longer weighing us down,
The code is leaner now all around! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'chore: cleanup unused dependencies' accurately reflects the main change across all three modified files, which consistently removes unused dependencies from their Cargo.toml files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch chore/remove-unused-dependencies

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.20%. Comparing base (88e8a9a) to head (8aeba02).
⚠️ Report is 1 commits behind head on v0.42-dev.

Additional details and impacted files

@@              Coverage Diff              @@
##           v0.42-dev     #633      +/-   ##
=============================================
+ Coverage      67.81%   68.20%   +0.38%     
=============================================
  Files            318      318              
  Lines          67976    67976              
=============================================
+ Hits           46100    46361     +261     
+ Misses         21876    21615     -261     

Flag	Coverage Δ
core	75.21% <ø> (ø)
ffi	40.78% <ø> (+2.49%)	⬆️
rpc	19.92% <ø> (ø)
spv	85.23% <ø> (ø)
wallet	67.56% <ø> (ø)
see 22 files with indirect coverage changes

[ZocoLini]

there is something interesting that I was exploring but not sure if it would break platform repo builds. key-wallet uses bincode only to serialize the wallet (maybe its key-wallet-ffi who serializes the wallet, not sure right now but the idea its the same), but at the same time implements serde for everything that implements bincode, we could remove thousands of lines and maybe reduce build time and size by removing all the bincode implementations and use bincode::serde package to serialize though serde framework