Skip to content

review: address PR feedback — real visit_seq test + debug_assert over…

3e74bd8
Select commit
Loading
Failed to load commit list.
Merged

fix(hashes): make SerdeHash tolerant of ContentDeserializer's HR-quirk #729

review: address PR feedback — real visit_seq test + debug_assert over…
3e74bd8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 5, 2026 in 1s

71.00% (+0.03%) compared to d67cc03

View this Pull Request on Codecov

71.00% (+0.03%) compared to d67cc03

Details

Codecov Report

❌ Patch coverage is 90.47619% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.00%. Comparing base (d67cc03) to head (3e74bd8).
⚠️ Report is 1 commits behind head on v0.42-dev.

Files with missing lines Patch % Lines
hashes/src/serde_macros.rs 80.48% 8 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           v0.42-dev     #729      +/-   ##
=============================================
+ Coverage      70.96%   71.00%   +0.03%     
=============================================
  Files            319      319              
  Lines          68387    68457      +70     
=============================================
+ Hits           48531    48605      +74     
+ Misses         19856    19852       -4     
Files with missing lines Coverage Δ
dash/src/hash_types.rs 63.87% <100.00%> (+13.87%) ⬆️
hashes/src/serde_macros.rs 85.91% <80.48%> (+20.00%) ⬆️

... and 3 files with indirect coverage changes