Skip to content

chore(dash-spv): forbid std::sync::Mutex / RwLock via clippy#739

Merged
xdustinface merged 1 commit into
v0.42-devfrom
chore/forbid-std-sync-in-dash-spv
May 6, 2026
Merged

chore(dash-spv): forbid std::sync::Mutex / RwLock via clippy#739
xdustinface merged 1 commit into
v0.42-devfrom
chore/forbid-std-sync-in-dash-spv

Conversation

@ZocoLini
Copy link
Copy Markdown
Collaborator

@ZocoLini ZocoLini commented May 6, 2026

Adds a clippy.toml with disallowed-types for std::sync::Mutex and std::sync::RwLock in dash-spv so callers are nudged toward the tokio equivalents (the crate is async/tokio throughout, a blocking lock can stall the runtime).

Adds a `clippy.toml` with `disallowed-types` for `std::sync::Mutex`
and `std::sync::RwLock` so callers are nudged toward the
tokio equivalents (the crate is async/tokio throughout — a blocking
lock can stall the runtime).
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 6, 2026

Warning

Rate limit exceeded

@ZocoLini has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 38 minutes and 48 seconds before requesting another review.

To continue reviewing without waiting, purchase usage credits in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d627154f-5e4b-4a64-a78f-c81236e76e50

📥 Commits

Reviewing files that changed from the base of the PR and between cab6d7d and 772f174.

📒 Files selected for processing (2)
  • dash-spv/clippy.toml
  • dash-spv/src/lib.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/forbid-std-sync-in-dash-spv

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ZocoLini ZocoLini requested a review from xdustinface May 6, 2026 16:29
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.43%. Comparing base (cab6d7d) to head (772f174).

Additional details and impacted files
@@              Coverage Diff              @@
##           v0.42-dev     #739      +/-   ##
=============================================
- Coverage      71.44%   71.43%   -0.02%     
=============================================
  Files            320      320              
  Lines          68825    68825              
=============================================
- Hits           49171    49162       -9     
- Misses         19654    19663       +9     
Flag Coverage Δ
core 76.51% <ø> (ø)
ffi 46.25% <ø> (+0.01%) ⬆️
rpc 20.00% <ø> (ø)
spv 87.44% <ø> (-0.07%) ⬇️
wallet 70.07% <ø> (ø)
see 3 files with indirect coverage changes

@xdustinface xdustinface merged commit 16ad9c9 into v0.42-dev May 6, 2026
37 checks passed
@xdustinface xdustinface deleted the chore/forbid-std-sync-in-dash-spv branch May 6, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants