test(dash-spv): fix create_test_wallet import in tests_transaction

[xdustinface]

CI on v0.42-dev is currently failing because #740 moved create_test_wallet from dashd_sync/setup.rs to dash_spv::test_utils and changed setup.rs to a private re-import. #748 was authored against an earlier base where setup.rs still defined a local pub(super) fn create_test_wallet, so the new tests in tests_transaction.rs imported it via super::setup.

Switch the import to dash_spv::test_utils, matching tests_basic.rs, tests_mempool.rs, tests_multi_wallet.rs, and tests_restart.rs.

Summary by CodeRabbit

Release Notes

No user-facing changes

This release includes internal test infrastructure updates to reorganize module imports, with no impact on end-user functionality or features.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 29ecba37-dac0-4b8d-b5ee-81ab839d0fc1

📥 Commits

Reviewing files that changed from the base of the PR and between 91056b7 and 407109b.

📒 Files selected for processing (1)

• dash-spv/tests/dashd_sync/tests_transaction.rs

---

📝 Walkthrough

Walkthrough

Import declarations in the transaction test file are reorganized to source create_test_wallet from dash_spv::test_utils rather than super::setup. The super::setup module now imports only create_and_start_client and TestContext. No functional logic changes.

Changes

Test Import Reorganization

Layer / File(s)	Summary
Test Module Imports dash-spv/tests/dashd_sync/tests_transaction.rs	create_test_wallet is sourced from dash_spv::test_utils instead of super::setup; super::setup import list reduced to create_and_start_client and TestContext.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A tiny shuffle of the imports neat,
Where test utilities find their seat,
From setup to utils, a cleaner way,
The transaction tests hop and play! 🐇

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: fixing an incorrect import of create_test_wallet in the tests_transaction file to use the correct module path.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch tests/fix-create-test-wallet-import

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.20%. Comparing base (91056b7) to head (407109b).

Additional details and impacted files

@@              Coverage Diff              @@
##           v0.42-dev     #751      +/-   ##
=============================================
+ Coverage      67.11%   72.20%   +5.08%     
=============================================
  Files            235      320      +85     
  Lines          53944    69631   +15687     
=============================================
+ Hits           36204    50274   +14070     
- Misses         17740    19357    +1617     

Flag	Coverage Δ
core	76.30% <ø> (ø)
ffi	45.27% <ø> (-0.02%)	⬇️
rpc	20.00% <ø> (ø)
spv	89.69% <ø> (?)
wallet	71.22% <ø> (ø)
see 86 files with indirect coverage changes