feat(model/qwen-tts): add param language_type#59
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @songguocola, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the Qwen Text-to-Speech (TTS) capabilities within the dashscope library by adding a language_type parameter, which provides explicit control over the language of the synthesized audio. It also improves the API's usability by making the voice selection a direct argument and updates the example usage to reflect these changes and incorporate more robust error handling.
Highlights
- New
language_typeParameter: Introduced a newlanguage_typeparameter for Qwen TTS, allowing users to specify the synthesized language, particularly for theqwen3-ttsmodel. - Refactored
voiceParameter: Thevoiceparameter has been promoted from a**kwargsargument to a direct parameter in theMultiModalConversation.callmethods for better clarity and control. - Updated Sample Code: The
test_qwen_tts.pysample has been updated to use theqwen3-tts-flashmodel, demonstrate the newlanguage_typeparameter, and include improved error handling for responses.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a language_type parameter for qwen-tts models, which is a useful addition. The changes are consistently applied across synchronous, asynchronous, and real-time streaming methods. My review includes suggestions to refactor some repetitive code for better maintainability and points out a potential point of confusion in one of the updated sample files.
| if text is not None and text: | ||
| input.update({'text': text}) | ||
| if voice is not None and voice: | ||
| input.update({'voice': voice}) | ||
| if language_type is not None and language_type: | ||
| input.update({'language_type': language_type}) |
There was a problem hiding this comment.
The conditional checks to add text, voice, and language_type to the input dictionary are repetitive. This can be refactored into a loop to improve code readability and make it easier to add more optional parameters in the future.
| if text is not None and text: | |
| input.update({'text': text}) | |
| if voice is not None and voice: | |
| input.update({'voice': voice}) | |
| if language_type is not None and language_type: | |
| input.update({'language_type': language_type}) | |
| for key, value in (('text', text), ('voice', voice), ('language_type', language_type)): | |
| if value: | |
| input[key] = value |
No description provided.