Skip to content

feat:(model/qwen3-livetranslate/asr/cosyvoice|app/multimodal-dialog)add input params#67

Merged
kevinlin09 merged 3 commits intodashscope:mainfrom
songguocola:dev/multimodal_2510_2
Oct 23, 2025
Merged

feat:(model/qwen3-livetranslate/asr/cosyvoice|app/multimodal-dialog)add input params#67
kevinlin09 merged 3 commits intodashscope:mainfrom
songguocola:dev/multimodal_2510_2

Conversation

@songguocola
Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @songguocola, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the configurability of real-time audio processing and multimodal interactions within the DashScope SDK. It introduces dedicated parameter structures for translation and transcription, allowing users to fine-tune these features for specific Qwen models. Additionally, it improves voice cloning with language hints and provides robust ASR post-processing options, including word replacement, to improve the accuracy and utility of speech-to-text functionalities.

Highlights

  • Real-time Audio Processing Parameters: Introduced new TranslationParams and TranscriptionParams dataclasses to allow for more granular control over real-time translation and transcription features in omni_realtime.py.
  • Enhanced Voice Creation: The create_voice method in enrollment.py now accepts an optional language_hints parameter, enabling users to specify target languages during voice cloning.
  • Advanced ASR Post-processing: Added AsrPostProcessing and ReplaceWord dataclasses in multimodal_request_params.py to support sophisticated ASR post-processing, including word replacement, and integrated these into the Upstream request parameters.
  • Updated update_session Method: The update_session method in omni_realtime.py was modified to accept the new translation_params and transcription_params, and the voice parameter was made optional.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new input parameters for live translation, ASR, and multimodal dialog functionalities, which is a good enhancement. My review focuses on improving the robustness and clarity of the new code. I've identified a critical issue in omni_realtime.py where a parameter is being incorrectly overwritten, and a high-severity issue regarding ambiguous parameter handling. I've also included several medium-severity suggestions to improve docstrings, type hinting, and dictionary construction for better code maintainability and correctness.

Comment thread dashscope/audio/qwen_omni/omni_realtime.py
Comment thread dashscope/audio/qwen_omni/omni_realtime.py
Comment thread dashscope/audio/qwen_omni/omni_realtime.py
Comment thread dashscope/multimodal/multimodal_request_params.py
Comment thread dashscope/multimodal/multimodal_request_params.py
@kevinlin09 kevinlin09 merged commit da1fa24 into dashscope:main Oct 23, 2025
@songguocola songguocola deleted the dev/multimodal_2510_2 branch November 3, 2025 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants