Ensure unique shuffle IDs in hash join #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjzamora
reviewed
Oct 25, 2023
Member
rjzamora
left a comment
rjzamora
left a comment
There was a problem hiding this comment.
Change looks good to me. Any ideas for a simple test? Perhaps you can just generate the graph twice (e.g. df1.merge(df2, ...).dask) and compare keys?
phofl
approved these changes
Oct 26, 2023
Collaborator
|
Some context: @hendrikmakait and I looked into this. The fix is valid and something I missed when initially implementing the HashJoin layer, but it should not have been necessary where this started failing (query 7). The optimization messes something up when we have more than one row group per file. I will look into this. This will also get a follow up that is more precise about the left and right keys (similar to what is currently in distributed) |
Collaborator
|
thx @hendrikmakait |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
P2P shuffling requires shuffle IDs to be unique. This PR makes sure that they are unique even if dataframes get reused in the same or several subsequent shuffles with different parameters.
Fixes dask/distributed#8301