Remove Expr._required_attribute
#799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Member
Author
|
Note that CI failures are unrelated: #801 |
phofl
approved these changes
Jan 29, 2024
Collaborator
|
thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_required_attributecheck was meant to avoid infiniteAttributeErrorrecursion. However, we can also avoid this recursion by expanding the current "_meta" check inExpr.__getattr__to throw aRuntimeErrorwhen the key is anything that starts with"_meta"(e.g. "_meta_chunk").This PR also consolidates the redundant
dask_expr._expr.Expr.__getattr__anddask_expr._core.Expr.__getattr__logic in once place. However, I can revert that change if there were two nearly-identical definitions for a reason.