Add list conversion to determine_column_projection
#853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjzamora
commented
Feb 6, 2024
phofl
reviewed
Feb 7, 2024
| assert_eq(df, ddf) | ||
|
|
||
|
|
||
| def test_parent_mixed_column_assignment(): |
Collaborator
There was a problem hiding this comment.
Can we somehow check that this test can be computed?
I ran into a test in dask/dask that gave me troubles until I figured out that the test doesn't even work in dask/dask if you call compute on it
Member
Author
There was a problem hiding this comment.
Ah good point. The test did "compute" before, but most of the result was NaN. I revised the logic a bit to represent something more realistic.
phofl
approved these changes
Feb 7, 2024
Collaborator
|
thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #842, I'm seeing a new test failure in
dask_cudf. It seems that we need to convert the output of_sort_mixedtolist.