Skip to content

Conversation

@phofl
Copy link
Collaborator

@phofl phofl commented Mar 8, 2024

cc @crusaderky

Potential fix, but I don't know task shuffles well enough to judge if this is a bad idea

@crusaderky
Copy link
Collaborator

@crusaderky
Copy link
Collaborator

crusaderky commented Mar 8, 2024

This changes the prefixes in dask-expr from ['split-taskshuffle', 'split-stage'] to ['split-operation', 'split-stage']
while dask/dataframe generates ['split-shuffle'].
Not sure this was the intent?

@phofl
Copy link
Collaborator Author

phofl commented Mar 8, 2024

Wrong variable, sorry. Using the correct variable that is also used in dask/dask creates cycles. We are building the graph differently here. So closing this since it's not urgent.

@phofl phofl closed this Mar 8, 2024
@phofl phofl deleted the task-shuffle-keys branch March 8, 2024 17:23
@phofl
Copy link
Collaborator Author

phofl commented Mar 8, 2024

Not sure this was the intent?

No that wasn't the intent, you are correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants