Retry scheduler connect multiple times #3104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrocklin
reviewed
Sep 30, 2019
Member
|
Any thoughts on how to test this? I can't think of any, but I thought I'd ask. |
Member
Author
|
It's a tricky one as this is trying to fix a strange edge case. Mocking the connect to timeout and then succeed would work, but that is very much code testing that the code does what the code does*, rather than actually testing a real example. Perhaps something fancy with iptables could do it. But I'm not sure if it is worth the effort. *intentionally unpleasant sentence |
Member
|
Yeah, that was my sense as well. Just thought I'd ask. Happy to merge on passed CI. |
4 tasks
jacobtomlinson
added a commit
to jacobtomlinson/dask-kubernetes
that referenced
this pull request
Oct 1, 2019
…he race condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3084
Instead of waiting for the scheduler connection for a long time we are waiting for a shorter time but retrying until the original timeout. If the connection is never made then we raise.