UCX simplify receiving frames in comms#3651
Merged
quasiben merged 6 commits intodask:masterfrom Mar 27, 2020
Merged
Conversation
Should make it easier to disambiguate things like `frame` and `frames` as they are now `each_frame` and `frames`.
Member
|
Looks good to me. @pentschev do you have any comments before we merge ? |
Member
|
LGTM as well. I'll just do a quick test for peace of mind and reported back here in a few minutes, but it should be fine. |
pentschev
approved these changes
Mar 27, 2020
Member
pentschev
left a comment
pentschev
left a comment
There was a problem hiding this comment.
Some testing presents no problems, from my side it's good to merge. Thanks @jakirkham !
quasiben
approved these changes
Mar 27, 2020
Member
Author
|
Thanks Ben and Peter! 😀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically a redux of PR ( #3599 ) with UCX changes only.
Simplifies the logic for receiving frames in
ucx. Also preallocates buffers to receive data into beforehand (and subselects the non-0-length buffers). Then hands off control to the underlying library receiving data to fill these buffers. Afterwards handles any sanity checks.cc @quasiben @pentschev