-
-
Notifications
You must be signed in to change notification settings - Fork 748
Transmit Layer annotations to scheduler #4279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transmit Layer annotations to scheduler #4279
Conversation
|
Depends on dask/dask#6889 |
19b83ad to
dadc7ac
Compare
|
I have an alternative here: #4288 It's not quite as comprehensive (annotations other than priority/retires/workers don't get transmitted) but it's simple and this approach covers what we can do today I think. |
…tions-to-scheduler
Should have been removed in dask@03e0046
mrocklin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments. Some are somewhat pedantic. I hope that that is ok.
No complaints here. The above makes sense to me and I think I understand where you're coming from, as I've been labelled "fussy about how things are done" upon occasion. ;-) |
|
This all seems good to me. I'm happy to merge. For future work (or now, if you feel like you're on a roll) we might consider assigning the annotations to the >>> ts.annotations
{"foo": 1}The test failure here seems unrelated. I'll push up a separate PR with a fix. |
Done. One of the future additions I'm considering is transmitting annotations to the workers, but I haven't looked into any of the details yet. I think it would be good to leave that to the scope of a new PR. |
|
It looks like this checked an empty file, |
|
Thanks for catching that, I believe it can be dropped |
No description provided.