Skip to content

Conversation

@jakirkham
Copy link
Member

@jakirkham jakirkham commented Dec 3, 2020

Fixes an issue we are seeing on CI. This came up for us in RAPIDS and this solved the issue there as well. Basically pip's solver seems to be trying to get involved here even though we don't need it to. Specifying the repo branches seems to bypass the issue.

This also came up in dask-cloudprovider recently ( dask/dask-cloudprovider#203 ).

@jakirkham
Copy link
Member Author

cc @dask/maintenance

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems totally sensible, especially if it fixes CI failures. Will merge once CI finishes

@jrbourbeau jrbourbeau merged commit 1c86be3 into dask:master Dec 3, 2020
@jakirkham jakirkham deleted the fix_pip_ci branch December 3, 2020 22:11
@jakirkham
Copy link
Member Author

Thanks James! 😄

@jrbourbeau
Copy link
Member

Hmm FWIW it looks like we may still be experiencing this pip install issue (see https://github.com/dask/distributed/pull/4313/checks?check_run_id=1496700929)

@jakirkham
Copy link
Member Author

Was also seeing that until rebasing on latest master. GitHub Actions may not be merging PRs with master before testing unlike other CIs (though CircleCI behaves similarly).

@jakirkham
Copy link
Member Author

Provided a more detailed response here ( #4313 (comment) ). HTH

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants