Coerce new TaskState.nbytes value to int
#4311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that whatever value we assign to `nbytes` is an `int`. This is important as `Schedule.bandwidth` may be a `float`. So the value here could be a `float`. Though we only measure `nbytes` in whole values.
jrbourbeau
reviewed
Dec 3, 2020
Member
jrbourbeau
left a comment
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @jakirkham! This LGTM. Just wanted to point out that nbytes starts out as None
distributed/distributed/scheduler.py
Line 721 in 1c86be3
Will that impact any Cython-related type checking?
Member
Author
|
It does, but we are already fixing that in PR ( #4302 ). TL;DR We fix this by setting it to |
jrbourbeau
approved these changes
Dec 3, 2020
Member
jrbourbeau
left a comment
jrbourbeau
left a comment
There was a problem hiding this comment.
+1, thanks for the explanation @jakirkham
Member
Author
|
Ofc. Thanks for the review! 😄 |
jakirkham
added a commit
to jakirkham/distributed
that referenced
this pull request
Dec 3, 2020
Make sure that whatever value we assign to `nbytes` is an `int`. This is important as `Schedule.bandwidth` may be a `float`. So the value here could be a `float`. Though we only measure `nbytes` in whole values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that whatever value we assign to
nbytesis anint. This is important asSchedule.bandwidthmay be afloat. So the value here could be afloat. Though we only measurenbytesin whole values.