Cache is_coroutine_function #4481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakirkham
reviewed
Feb 4, 2021
Member
jakirkham
left a comment
jakirkham
left a comment
There was a problem hiding this comment.
Thanks Ian! 😄
This looks good generally. Had a couple questions on the details
jakirkham
reviewed
Feb 4, 2021
Member
jakirkham
left a comment
jakirkham
left a comment
There was a problem hiding this comment.
Thanks Ian! 😄
Looks like there is small naming error on CI. Also made one minor aliasing suggestion
ian-r-rose
force-pushed
the
cache-is-coroutine-function
branch
from
cf0cdf9 to
7a9fba0
Compare
mitigate re-checking the same function many times. Decorate function definition, cache all function definitions. Oops, cache is python 3.9-only Alias duplicate function. Use distributed's version of this util. bad rebase.
jakirkham
approved these changes
Feb 4, 2021
ian-r-rose
force-pushed
the
cache-is-coroutine-function
branch
from
982baad to
893a91f
Compare
Member
|
Thanks Ian! 😄 |
Collaborator
Author
|
Thanks for the review @jakirkham! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4469 , fixes #4482, fixes #4483, alternative to #4474
Uses cached version of
is_coroutine_functionin stream handling to mitigate re-checking the same function many times.black distributed/flake8 distributed