Avoid list mutation in pickle_loads #4653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakirkham
reviewed
Mar 30, 2021
|
|
||
| new = [] | ||
| memoryviews = map(memoryview, buffers) | ||
| for writeable, mv in zip(header["writeable"], memoryviews): |
Member
There was a problem hiding this comment.
This would be an issue if header["writeable"] is (), which came up in another issue ( #4645 (comment) )
Member
Author
There was a problem hiding this comment.
This PR is focused on removing the list mutation. I recommend that we handle the not header["writeable"] issue separately if that's ok.
3 tasks
…-mutation-pickle-loads
Contributor
|
can confirm this fixes the specific regression affecting us (no idea about the broader impact though) |
…tributed into avoid-mutation-pickle-loads
Member
Author
|
Merging on passed tests. @jrbourbeau can we schedule a bugfix release for this Friday at the latest? I'll resolve the writeable thing too. |
Member
|
Yeah I was trying to prod CI last night, but I guess it still wasn't passing unfortunately (not that I think the failure is related) |
Member
|
See dask/community#144 for the bugfix release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4625
black distributed/flake8 distributed