Adjust timings in test_threadpoolworkers #4681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjetter
force-pushed
the
gh/4680/flaky_threadpoolworkers_pick_loop
branch
from
bfd22b5 to
6d7fd69
Compare
jrbourbeau
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't reproduce the test failures locally but with these timings it should be robust enough to not be flaky anymore
I believe the issue occurred due to the hard coded lease-timeout / 5 for the internal refresh PC interval which is the same as the validation interval.
test_threadpoolworkers_pick_correct_ioloop#4680black distributed/flake8 distributed/isort distributed