Remove passing of kwargs to super in Server #4789
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrbourbeau
reviewed
May 6, 2021
Member
jrbourbeau
left a comment
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @jacobtomlinson! This is similar to #4733 where it was proposed that we remove extra kwargs to Server altogether.
Member
Author
|
Ah awesome, I hadn't spotted that. Closing this in favour of #4733. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black distributed/flake8 distributed/isort distributedThe
super()ofdistributed.core.Serverisobjectwhich doesn't take any kwargs. So if there are any kwargs left over inServerit raises an unhelpful error.This PR raises more helpful exceptions, but we may want to consider just removing the
**kwargsfrom theServer.__init__all together.