Who has has what html reprs v2 #4865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrbourbeau
reviewed
Jun 1, 2021
Member
jrbourbeau
left a comment
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @jacobtomlinson! This looks great
@jakirkham @dantegd FYI this shouldn't cause any cuml breakages like we were seeing earlier -- though do let us know if anything pops up
Co-authored-by: James Bourbeau <jrbourbeau@users.noreply.github.com>
jrbourbeau
approved these changes
Jun 2, 2021
Member
jrbourbeau
left a comment
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @jacobtomlinson! Just bumped CI to make sure test failures are unrelated to the changes here. Will merge after CI finishes
Member
Author
|
@jrbourbeau failure looks unrelated, what do you think? |
Member
|
Yep, definitely unrelated (xref #4862) -- merging |
douglasdavis
pushed a commit
to douglasdavis/distributed
that referenced
this pull request
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for #4853 which was reverted with support for async calls.
cc @mrocklin @jrbourbeau @jakirkham @quasiben @crusaderky