keep dependents in worker dependency if TS is still known #5034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjetter
force-pushed
the
worker_keep_dependents_static
branch
2 times, most recently
from
ba626ff to
c07b8ef
Compare
Unless the task is entirely forgotten by the worker it is confusing behaviour if the dependent or a task is removed once it finished executing. if this information is required a dedicated dynamic attribute should be used like waiters on the scheduler side
fjetter
force-pushed
the
worker_keep_dependents_static
branch
from
c07b8ef to
5f2b72e
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless the task is entirely forgotten by
the worker it is confusing behaviour if
the dependent or a task is removed
once it finished executing. if this
information is required a dedicated
dynamic attribute should be used like
waiters on the scheduler side