Deprecate worker plugin overwrite policy #5146
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current when a worker plugin is registered with the same name as an already registered plugin, we do not overwrite the previously registered plugin.
distributed/distributed/worker.py
Lines 2724 to 2725 in 1999c15
However, with nanny plugins this behavior is different and we do overwrite previously registered plugins with the same name. To avoid user confusion, this PR proposes we deprecate our current worker plugin overwrite behavior to match the existing nanny plugin semantic. This will be, I think, more intuitive and will maintainable (xref #5127 (comment)).