Skip to content

Conversation

@jrbourbeau
Copy link
Member

Current when a worker plugin is registered with the same name as an already registered plugin, we do not overwrite the previously registered plugin.

if name in self.plugins:
return {"status": "repeat"}

However, with nanny plugins this behavior is different and we do overwrite previously registered plugins with the same name. To avoid user confusion, this PR proposes we deprecate our current worker plugin overwrite behavior to match the existing nanny plugin semantic. This will be, I think, more intuitive and will maintainable (xref #5127 (comment)).

@jrbourbeau
Copy link
Member Author

jrbourbeau commented Aug 2, 2021

I'll plan to leave this open for a couple more days. If there's no objection, I'll merge this in so it will be in the next release. After that, the plan would be to merge in something like #5142 which actually modifies worker plugin repeat behavior

@jrbourbeau jrbourbeau merged commit 9fc7e31 into dask:main Aug 5, 2021
@jrbourbeau jrbourbeau deleted the change-worker-plugin-repeat branch August 5, 2021 18:12
@jrbourbeau jrbourbeau mentioned this pull request Aug 23, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant