Skip to content

Install pickle5 in Python 3.7 CI jobs #5302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jakirkham wants to merge 1 commit into from
Closed

Install pickle5 in Python 3.7 CI jobs #5302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,12 @@ jobs:
shell: bash -l {0}
run: conda config --show

- name: Optionally install pickle5
shell: bash -l {0}
# pickle5 is used for out-of-band pickling support in Python 3.7
if: ${{ matrix.os == 'ubuntu-latest' && matrix.python-version < '3.8' }}
run: mamba install -c conda-forge pickle5
Copy link
Member Author

@jakirkham jakirkham Sep 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth limiting this to only some Python 3.7 CI jobs given it is still useful to test without pickle5. Though it would be good to have some Python 3.7 jobs that include this.

Not sure how we want to handle that (see partitions above, which might be a useful way to handle this). Though maybe there are better ways.

Copy link
Member Author

@jakirkham jakirkham Sep 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed by testing both pickle protocol 4 & 5 in PR ( #5313 ).


- name: Install stacktrace
shell: bash -l {0}
# stacktrace for Python 3.8 has not been released at the moment of writing
Expand Down