Fix flaky test_robust_to_bad_sizeof_estimates #5753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusaderky
commented
Feb 3, 2022
| config={ | ||
| "distributed.worker.memory.target": False, | ||
| "distributed.worker.memory.spill": 0.7, | ||
| }, |
Collaborator
Author
There was a problem hiding this comment.
no change from default for spill, but I like to spell out explicitly relevant settings - also in the case they change in the future
crusaderky
commented
Feb 3, 2022
| """ | ||
| memory = s.workers[a.address].memory.process | ||
| # Reach 'spill' threshold after 400MB of managed data | ||
| a.memory_limit = memory / 0.7 + 400e6 |
Collaborator
Author
There was a problem hiding this comment.
Note that this works just by luck today for the purpose of the spill threshold, and does NOT work for the target threshold. See #5367
gjoseph92
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix occasional flakiness in test:
https://github.com/dask/distributed/runs/5036808926?check_suite_focus=true
The test hung on a 5s timeout. I think it's because the OS could not write to disk 100MB worth of data fast enough.