Prevent data duplication on unspill #5936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusaderky
force-pushed
the
unspill_duplication
branch
from
0926bcc to
ae5edf5
Compare
Contributor
Unit Test Results 12 files ± 0 12 suites ±0 5h 48m 34s ⏱️ + 1m 22s For more details on these failures, see this check. Results for commit 398783d. ± Comparison against base commit 2fffe74. ♻️ This comment has been updated with latest results. |
crusaderky
force-pushed
the
unspill_duplication
branch
4 times, most recently
from
4bec938 to
7843d4f
Compare
fjetter
reviewed
Mar 14, 2022
Member
fjetter
left a comment
fjetter
left a comment
There was a problem hiding this comment.
Very nice! Looking forward to having this in! Changes LGTM once zict is merged, etc.
crusaderky
force-pushed
the
unspill_duplication
branch
from
7843d4f to
f4c649c
Compare
crusaderky
commented
Mar 14, 2022
crusaderky
commented
Mar 14, 2022
crusaderky
commented
Mar 14, 2022
| assert buf.slow.weight_by_key == {"a": psize(a)} | ||
| assert_buf(buf, {"bad": bad}, {"a": a}) | ||
|
|
||
|
|
Collaborator
Author
There was a problem hiding this comment.
new test start here; everything else in this module is just a refactor
Collaborator
Author
|
Removed blockers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.