Make test_reconnect async #6000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjetter
reviewed
Mar 25, 2022
This was flakey due to cleaning up resources. My experience is that making things async helps with this in general. I don't have strong confidence that this will fix the issue, but I do have mild confidence, and strong confidence that it won't hurt.
mrocklin
force-pushed
the
test-reconect-async
branch
from
25f6966 to
9262524
Compare
Contributor
Unit Test Results 18 files + 6 18 suites +6 9h 45m 12s ⏱️ + 3h 46m 11s For more details on these failures, see this check. Results for commit aa8c7d9. ± Comparison against base commit 2fbf9eb. ♻️ This comment has been updated with latest results. |
Member
Author
|
Planning to merge when CI finishes |
Member
Author
|
Nope, this still fails |
Member
Author
|
Merging when CI finishes |
mrocklin
added a commit
to mrocklin/distributed
that referenced
this pull request
Mar 31, 2022
This was flakey due to cleaning up resources. My experience is that making things async helps with this in general. I don't have strong confidence that this will fix the issue, but I do have mild confidence, and strong confidence that it won't hurt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was flakey due to cleaning up resources.
My experience is that making things async helps with this in general.
I don't have strong confidence that this will fix the issue, but I do
have mild confidence, and strong confidence that it won't hurt.
pre-commit run --all-files