Skip to content

Support stimulus_id's via Wrapped RPC handlers and ContextVars #6010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sjperkins wants to merge 30 commits into from
Closed

Support stimulus_id's via Wrapped RPC handlers and ContextVars #6010

sjperkins wants to merge 30 commits into from

Conversation

@sjperkins
Copy link
Member

@sjperkins sjperkins commented Mar 28, 2022

@sjperkins sjperkins marked this pull request as draft March 28, 2022 15:06
@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2022 •
edited
Loading

Unit Test Results

       13 files   -        5         13 suites   - 5   6h 22m 48s ⏱️ - 3h 30m 1s
  2 705 tests +       2    2 610 ✔️  -        8    86 💤 +    4  9 ❌ +6 
16 161 runs   - 8 002  15 313 ✔️  - 7 558  839 💤  - 449  9 ❌ +5 

For more details on these failures, see this check.

Results for commit a07bbec. ± Comparison against base commit e601e79.

♻️ This comment has been updated with latest results.

sjperkins added 20 commits March 29, 2022 11:25
@sjperkins
Merge branch 'main' into contextvar-stimulus-id
b2a198f
@sjperkins
Handler -> RPCHandler
f65663f
@sjperkins
Replace stimulus_id usage with a ContextVar throughout Scheduler and
268a905 
Worker
@sjperkins
Merge branch 'main' into contextvar-stimulus-id
f9d949b
@sjperkins
Simplify RPCHandler constructor
757cf36
@sjperkins
assert_worker_story -> assert_story
ad00285
@sjperkins
Add scheduler story test
64de8e2
@sjperkins
Validate stimulus_id's entered into Worker log during testing
d70aeec
@sjperkins
Remove stimulus_id's from various test cases
6f49f92
@sjperkins
Merge branch 'main' into contextvar-stimulus-id
8eed6a1
@sjperkins
Tighten up RPCHandler tests
3a65fce
@sjperkins
Deal with RPCHandler in has_keyword
73ede3e
@sjperkins
Add partial inheritance test
0eaa794
@sjperkins
Add comment noting tpe.map defers to tpe.submit
681669e
@sjperkins
STIMULUS_ID improvements
fb7eba8
@sjperkins
Remove crufty check
62fdd4f
@sjperkins
Remove context_vars check. Difficult to test ContextVars in isolation
126a702
@sjperkins
Stringify story keys on scheduler and worker
61ff8a4
@sjperkins
First stimulus story test
275ea7d
@sjperkins
Merge branch 'main' into contextvar-stimulus-id
35b70d5
@sjperkins
Copy link
Member Author

sjperkins commented Apr 4, 2022

Closing in favour of #6046

@sjperkins sjperkins closed this Apr 4, 2022
@sjperkins sjperkins deleted the contextvar-stimulus-id branch April 8, 2022 15:20
@sjperkins sjperkins mentioned this pull request Apr 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fjetter fjetter Awaiting requested review from fjetter fjetter will be requested when the pull request is marked ready for review fjetter is a code owner

Assignees

@sjperkins sjperkins

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Transition tracing for scheduler task transitions

1 participant

@sjperkins