Ensure multiple clients can cancel their key without interference #6016
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encountered this during #6005
I assume the indentation of the
Scheduler.reportwas done wrong in one of the bigger refactorings going on. The test passed because of two problems with the testc.cancelcould run synchronously. Therefore, clientcmarked the future already as cancelled but Clientfdidn't receive the message of the scheduler, yet. Therefore the asserts on the FutureState were successful. Since the scheduler didn't actually cancel the key,ycould be properly awaited.fnorcto be actually registered, thecancel_keyuses it's retry feature that returns immediately and schedules another callback. On busy CI / stress, this callback could be scheduled before the second client is registered to the scheduler, therefore, the second client would never receive the erroneous cancellation report