ToPickle support of the inproc protocol #6044
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
madsbk
force-pushed
the
to_pickle_support_inproc
branch
from
a67982a to
47300ba
Compare
madsbk
force-pushed
the
to_pickle_support_inproc
branch
from
47300ba to
2ba4b41
Compare
Contributor
Author
|
@mrocklin this is ready for review. |
Member
|
Thanks. This isn't on my critical path right now, so I'm going to pass on review. (my branch doesn't actually use this, I call pickle.dumps/loads directly for various reasons) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement support of
ToPicklein theinprocprotocol.Also adding tests for the case where unpickle isn't allowed on the Scheduler.
pre-commit run --all-files