Type annotations for profile.py #6067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fjetter
approved these changes
Apr 6, 2022
Member
fjetter
left a comment
fjetter
left a comment
There was a problem hiding this comment.
LGTM. Feel free to merge after resolving merge conflicts and CI is green-ish
distributed/profile.py
Outdated
|
|
||
|
|
||
| def identifier(frame): | ||
| def identifier(frame) -> str: |
Member
There was a problem hiding this comment.
Any reason why you're never annotating the frame?
Suggested change
| def identifier(frame) -> str: | |
| def identifier(frame: types.FrameType) -> str: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offshoot from #6033