WIP Do not restart BatchedSend on worker reconnect #6266
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Unit Test Results 15 files - 1 15 suites - 1 7h 13m 22s ⏱️ - 10m 32s For more details on these failures and errors, see this check. Results for commit df383ae. ± Comparison against base commit c11c8ee. ♻️ This comment has been updated with latest results. |
graingert
reviewed
May 4, 2022
| pass | ||
| yield self.comm.close() | ||
| await self.comm.close() | ||
| await self._background_task |
Member
There was a problem hiding this comment.
waiting for self.stopped.wait() should only finish once self._background_task has - so this await should be redundant
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @gjoseph92 @graingert