Skip to content

Conversation

@sjperkins
Copy link
Member

Based on #6246

Closes #xxxx

  • Tests added / passed
  • Passes pre-commit run --all-files

@fjetter
Copy link
Member

fjetter commented May 5, 2022

I suggest to focus first on Scheduler and Worker instances before you tackle TaskState. That's a required step but much easier and we can get it merged incrementally

@sjperkins
Copy link
Member Author

sjperkins commented May 5, 2022

I suggest to focus first on Scheduler and Worker instances before you tackle TaskState. That's a required step but much easier and we can get it merged incrementally

Thanks. By this I think you mean deal with things in the following way in utils.check_instances?

# Fix leaks here first
if Scheduler._instances:
    scheduler = Scheduler._instances.pop()
    import objgraph

    objgraph.show_backrefs[worker], filename="scheduler.png"
assert not Scheduler._instances    

# Fix leaks here second
if Worker._instances:
    worker = Worker._instances.pop()
    import objgraph

    objgraph.show_backrefs[worker], filename="worker.png"
assert not Worker._instances    

# Fix leaks here last
if TaskState._instances:
    ts = TaskState._instances.pop()
    import objgraph

    objgraph.show_backrefs([ts], filename="taskstate.png")```

@sjperkins
Copy link
Member Author

I'll start a new PR to deal with Scheduler instances and then work to Worker and TaskState PR's incrementally.

@sjperkins
Copy link
Member Author

Closed in favour of #6281

@sjperkins sjperkins closed this May 5, 2022
@sjperkins sjperkins deleted the gc_scheduler_taskstate branch May 5, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants