Skip to content

Conversation

@crusaderky
Copy link
Collaborator

Reinstate #6237, which was closed by accident.

Don't leave cruft around the working directory. Prevent a wealth of problems for developers with their home directory on a network filesystem.

loop,
with tempfile.TemporaryDirectory() as tmpdir:
config2 = merge({"temporary-directory": tmpdir}, config)
with dask.config.set(config2):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything below this line is just an extra indentation

@crusaderky crusaderky self-assigned this May 13, 2022
Copy link
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

scheduler,
loop,
with tempfile.TemporaryDirectory() as tmpdir:
config2 = merge({"temporary-directory": tmpdir}, config)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I'd prefer a more meaningful name like merged_config, but it really doesn't matter given the current scope of usage.

@github-actions
Copy link
Contributor

Unit Test Results

       15 files  ±0         15 suites  ±0   6h 54m 59s ⏱️ - 4m 57s
  2 774 tests ±0    2 695 ✔️ +2    79 💤 +1  0  - 3 
20 580 runs  ±0  19 674 ✔️ ±0  906 💤 +3  0  - 3 

Results for commit a2ab457. ± Comparison against base commit 77cfc73.

@crusaderky crusaderky merged commit 2b04d8b into dask:main May 13, 2022
@crusaderky crusaderky deleted the gen_cluster_tmp branch May 13, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants