Skip to content

Conversation

@gjoseph92
Copy link
Collaborator

Introduced in #6146, which was putting a close message instead of stop:

try:
msg = child_stop_q.get()
except (TypeError, OSError, EOFError):
logger.error("Worker process died unexpectedly")
msg = {"op": "stop"}
finally:
child_stop_q.close()
assert msg["op"] == "stop", msg

This error was triggered in #6320, but clearly doesn't happen in CI normally. I have not tried to add a test for it. It was already untested when added.

cc @mrocklin @fjetter

  • Tests added / passed
  • Passes pre-commit run --all-files

Introduced in dask#6146. We don't know why this code path is only being triggered now.
@github-actions
Copy link
Contributor

Unit Test Results

       15 files  ±0         15 suites  ±0   6h 50m 34s ⏱️ - 13m 14s
  2 792 tests ±0    2 709 ✔️  - 5    79 💤 +1  3 +3  1 🔥 +1 
20 707 runs  +1  19 795 ✔️  - 1  908 💤  - 2  3 +3  1 🔥 +1 

For more details on these failures and errors, see this check.

Results for commit 5092403. ± Comparison against base commit 63cdddd.

@fjetter fjetter merged commit 0104410 into dask:main May 17, 2022
@mrocklin
Copy link
Member

My apologies. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants