Skip to content

Fix CLI Scheduler Tests #6502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fjetter merged 4 commits into from
Jun 8, 2022
Merged

Fix CLI Scheduler Tests #6502

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
138c827
try fixing scheduler dashboard tests by waiting just a bit/asserting …
quasiben Jun 3, 2022
2770875
try much higher port
quasiben Jun 3, 2022
047447c
forgot to flush output
quasiben Jun 3, 2022
46230a8
Merge branch 'main' of github.com:dask/distributed into fix-cli-tests
quasiben Jun 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions distributed/cli/tests/test_dask_scheduler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,22 +99,24 @@ def test_dashboard_non_standard_ports(loop):
pytest.importorskip("bokeh")

with popen(
["dask-scheduler", "--port", "3448", "--dashboard-address", ":4832"]
["dask-scheduler", "--port", "23448", "--dashboard-address", ":24832"],
flush_output=False,
) as proc:
with Client("127.0.0.1:3448", loop=loop) as c:
line = wait_for_log_line(b"dashboard at", proc.stdout)
with Client("127.0.0.1:23448", loop=loop) as c:
pass

start = time()
while True:
try:
response = requests.get("http://localhost:4832/status/")
response = requests.get("http://localhost:24832/status/")
assert response.ok
break
except Exception:
sleep(0.1)
assert time() < start + 20
with pytest.raises(Exception):
requests.get("http://localhost:4832/status/")
requests.get("http://localhost:24832/status/")


@pytest.mark.skipif(not LINUX, reason="Need 127.0.0.2 to mean localhost")
Expand Down Expand Up @@ -207,8 +209,10 @@ def check_pidfile(proc, pidfile):
def test_scheduler_port_zero(loop):
with tmpfile() as fn:
with popen(
["dask-scheduler", "--no-dashboard", "--scheduler-file", fn, "--port", "0"]
):
["dask-scheduler", "--no-dashboard", "--scheduler-file", fn, "--port", "0"],
flush_output=False,
) as proc:
line = wait_for_log_line(b"dashboard at", proc.stdout)
with Client(scheduler_file=fn, loop=loop) as c:
assert c.scheduler.port
assert c.scheduler.port != 8786
Expand Down