Default dashboard address configurable #6612
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This complements #6591
The default port for the dashboard or http server is hard coded to 8787. If this port is available, great. However, if a test doesn't properly cleanup after itself all following tests that are hard coded against this port for whatever reason are doomed to fail. We have a couple of these cascading failures on CI lately
This PR introduces a couple of changes
open_port. I didn't want to use open_port for all tests. Maybe that's paranoid?If we do not wan to have this kind of fixture magic in here, I can simplify this to use open_port all the time.