Skip to content

Conversation

@crusaderky
Copy link
Collaborator

Closes #6479

@crusaderky crusaderky force-pushed the forget_acquire_replicas branch from 18eca1d to 582623c Compare June 28, 2022 00:09
@crusaderky crusaderky force-pushed the forget_acquire_replicas branch from 582623c to 3c9c528 Compare June 28, 2022 00:11
@github-actions
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       15 files  ±0         15 suites  ±0   10h 20m 17s ⏱️ - 3m 21s
  2 898 tests +1    2 809 ✔️  - 4    82 💤  - 1  5 +5  2 🔥 +1 
21 467 runs  +9  20 499 ✔️ +3  959 💤  - 1  7 +6  2 🔥 +1 

For more details on these failures and errors, see this check.

Results for commit 3c9c528. ± Comparison against base commit a8eb3b2.

@crusaderky crusaderky marked this pull request as ready for review June 28, 2022 10:16
@crusaderky crusaderky self-assigned this Jun 28, 2022
Copy link
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me!

7. x is transitioned fetch -> missing
"""
x = await c.scatter({"x": 1}, workers=[b.address])
# Note: submit and scatter are different. If you lose all workers holding the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation of this change.

@crusaderky crusaderky merged commit bd7f43a into dask:main Jun 29, 2022
@crusaderky crusaderky deleted the forget_acquire_replicas branch June 29, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AMM can leave a forgotten task forever in missing state

2 participants