Remove test_restart_fast_sync, test_fast_kill
#6750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests were identical, and redundant with tests we already have. The "fast" aspect doesn't make sense to test in CI, restarting processes can actually be very, very slow on some CI workers.
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 14 files - 1 14 suites - 1 6h 14m 56s ⏱️ - 24m 21s For more details on these failures, see this check. Results for commit 1cf4d83. ± Comparison against base commit f30bacc. |
hendrikmakait
approved these changes
Jul 21, 2022
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests were identical, and redundant with tests we already have. The "fast" aspect doesn't make sense to test in CI; restarting processes can actually be very, very slow on some CI workers.
Closes #6746
pre-commit run --all-files