Skip to content

Bind UCX listener to specific IP address #6901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pentschev wants to merge 2 commits into from
Closed

Bind UCX listener to specific IP address #6901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbb731e
Bind UCX listener to specific IP address
pentschev Aug 17, 2022
bcce2b7
Test UCX listener's IP binding
pentschev Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions distributed/comm/tests/test_ucx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,6 +357,15 @@ async def test_ucx_protocol(ucx_loop, cleanup, port):
assert s.address.startswith("ucx://")


@gen_test()
async def test_ucx_listener_ip(ucx_loop, cleanup):
async with Scheduler(
protocol="ucx", interface="localhost", dashboard_address=":0"
) as s:
assert s.address.startswith("ucx://127.0.0.1")
assert s.listener.ucp.server.ip == "127.0.0.1"


@pytest.mark.skipif(
not hasattr(ucp.exceptions, "UCXUnreachable"),
reason="Requires UCX-Py support for UCXUnreachable exception",
Expand Down
4 changes: 3 additions & 1 deletion distributed/comm/ucx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,9 @@ async def serve_forever(client_ep):
await self.comm_handler(ucx)

init_once()
self.ucp_server = ucp.create_listener(serve_forever, port=self._input_port)
self.ucp_server = ucp.create_listener(
serve_forever, port=self._input_port, ip_address=self.ip
)

def stop(self):
self.ucp_server = None
Expand Down