Skip to content

Conversation

@hendrikmakait
Copy link
Member

Closes #xxxx

  • Tests added / passed
  • Passes pre-commit run --all-files

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2022

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       15 files  ±  0         15 suites  ±0   6h 6m 30s ⏱️ - 27m 57s
  3 154 tests  -   2    3 061 ✔️  -   3    83 💤  -   3  10 +  4 
23 332 runs   - 17  22 392 ✔️  - 20  899 💤  - 17  41 +20 

For more details on these failures, see this check.

Results for commit 25dc163. ± Comparison against base commit 0983731.

♻️ This comment has been updated with latest results.

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hendrikmakait I've not looked too closely at the changes here but they seem (at least indirectly) related to #7154. I was planning to push on some of your suggestions in #7154 -- should I hold off and wait for this PR to land first?

@hendrikmakait
Copy link
Member Author

@jrbourbeau: If you want to get the feature out, I think it's fine to merge #7154 without waiting for this. I can take care of adjustments that utilize the changes made here to improve alignment between Client.restart and Client.restart_workers. For context, this PR is sparked by a discussion with @fjetter around #7154 and the way Client.restart is currently implemented.

@hendrikmakait hendrikmakait changed the title Simplify Nanny.restart logic Simplify Scheduler.restart logic Oct 26, 2022
@hendrikmakait
Copy link
Member Author

Superseded by #7242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants