-
-
Notifications
You must be signed in to change notification settings - Fork 748
Simplify Scheduler.restart logic
#7184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ± 0 15 suites ±0 6h 6m 30s ⏱️ - 27m 57s For more details on these failures, see this check. Results for commit 25dc163. ± Comparison against base commit 0983731. ♻️ This comment has been updated with latest results. |
jrbourbeau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hendrikmakait I've not looked too closely at the changes here but they seem (at least indirectly) related to #7154. I was planning to push on some of your suggestions in #7154 -- should I hold off and wait for this PR to land first?
|
@jrbourbeau: If you want to get the feature out, I think it's fine to merge #7154 without waiting for this. I can take care of adjustments that utilize the changes made here to improve alignment between |
Nanny.restart logicScheduler.restart logic
|
Superseded by #7242 |
Closes #xxxx
pre-commit run --all-files