-
-
Notifications
You must be signed in to change notification settings - Fork 748
Fix tests for p2p by default #7595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,7 @@ | |
| np = pytest.importorskip("numpy") | ||
| pd = pytest.importorskip("pandas") | ||
|
|
||
| from packaging.version import parse as parse_version | ||
| from pandas.testing import assert_frame_equal, assert_index_equal, assert_series_equal | ||
|
|
||
| import dask | ||
|
|
@@ -109,6 +110,13 @@ async def test_dask_array_collections(c, s, a, b): | |
| np.testing.assert_equal(o_local, o_remote) | ||
|
|
||
|
|
||
| @pytest.mark.skipif( | ||
| ( | ||
| parse_version(dask.__version__) < parse_version("2023.2.2") | ||
| and parse_version(dask.__version__) >= parse_version("2023.2.1") | ||
| ), | ||
| reason="https://github.com/dask/dask/pull/10005", | ||
| ) | ||
| @gen_cluster(client=True) | ||
| async def test_bag_groupby_tasks_default(c, s, a, b): | ||
|
Comment on lines
+113
to
121
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I decided to skip this test to unblock our CI. dask/dask#10005 will introduce the same test in dask/dask, i.e. we could even remove it from distributed. keeping it here for early failures is still nice since the test is very cheap |
||
| b = db.range(100, npartitions=10) | ||
|
|
@@ -174,12 +182,12 @@ def test_dataframe_groupby_tasks(client): | |
| for ind in [lambda x: "A", lambda x: x.A]: | ||
| a = df.groupby(ind(df)).apply(len) | ||
| b = ddf.groupby(ind(ddf)).apply(len, meta=(None, int)) | ||
| assert_equal(a, b.compute(scheduler="sync").sort_index()) | ||
| assert_equal(a, b.compute().sort_index()) | ||
| assert not any("partd" in k[0] for k in b.dask) | ||
|
|
||
| a = df.groupby(ind(df)).B.apply(len) | ||
| b = ddf.groupby(ind(ddf)).B.apply(len, meta=("B", int)) | ||
| assert_equal(a, b.compute(scheduler="sync").sort_index()) | ||
| assert_equal(a, b.compute().sort_index()) | ||
| assert not any("partd" in k[0] for k in b.dask) | ||
|
|
||
| with pytest.raises((NotImplementedError, ValueError)): | ||
|
|
@@ -188,7 +196,7 @@ def test_dataframe_groupby_tasks(client): | |
| a = df.groupby(["A", "B"]).apply(len) | ||
| b = ddf.groupby(["A", "B"]).apply(len, meta=(None, int)) | ||
|
|
||
| assert_equal(a, b.compute(scheduler="sync").sort_index()) | ||
| assert_equal(a, b.compute().sort_index()) | ||
|
|
||
|
|
||
| @gen_cluster(client=True) | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My guess is we'll also want to use
check_minimal_arrow_version()to make sure we account forpyarrow<7being installed