Ensure en error during ShuffleRun.close cannot block worker shutdown #8184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 21 files ± 0 21 suites ±0 11h 3m 28s ⏱️ -18s For more details on these failures, see this check. Results for commit 2d9e1b6. ± Comparison against base commit 9895194. ♻️ This comment has been updated with latest results. |
graingert
reviewed
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any error during
ShuffleRun.closecan block the shutdown since the condition will block until the run is cleaned up. The exception is otherwise not handled and never retrieved. Therefore, we're logging it and clean up the state.An example of an exception that could happen here is the failure to remove files of the disk buffer. There are surely other "not great but OK" cases.