Skip to content

Annotations and better tests for serialize_bytes #8300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hendrikmakait merged 1 commit into from
Oct 24, 2023
Merged

Annotations and better tests for serialize_bytes #8300

hendrikmakait merged 1 commit into from
Oct 24, 2023

Conversation

@crusaderky
Copy link
Collaborator

@crusaderky crusaderky commented Oct 23, 2023 •
edited
Loading

@crusaderky crusaderky requested a review from fjetter as a code owner October 23, 2023 23:14
@crusaderky crusaderky self-assigned this Oct 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       27 files  ±  0         27 suites  ±0   14h 53m 4s ⏱️ - 1h 17m 55s
  3 936 tests +  4    3 817 ✔️ +10     115 💤 ±0    4 ❌  - 5 
49 439 runs  +52  47 071 ✔️ +60  2 342 💤 +1  26 ❌  - 8 

For more details on these failures, see this check.

Results for commit c551dab. ± Comparison against base commit b4eee3f.

milesgranger
milesgranger approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@milesgranger milesgranger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@milesgranger
Copy link
Contributor

milesgranger commented Oct 24, 2023

but just to clarify, the ci1 variants are failing, but seems that's happening on main also.

hendrikmakait
hendrikmakait approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @crusaderky!

@hendrikmakait hendrikmakait merged commit b4cfc0b into dask:main Oct 24, 2023
@crusaderky crusaderky deleted the protocol branch October 24, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hendrikmakait hendrikmakait hendrikmakait approved these changes

@fjetter fjetter Awaiting requested review from fjetter fjetter is a code owner

+1 more reviewer

@milesgranger milesgranger milesgranger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@crusaderky crusaderky

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crusaderky @milesgranger @hendrikmakait