Add close worker button to worker info page #8742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 29 files ±0 29 suites ±0 11h 19m 16s ⏱️ - 2m 2s For more details on these failures, see this check. Results for commit 860b69d. ± Comparison against base commit d36fc3c. ♻️ This comment has been updated with latest results. |
fjetter
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user recently mentioned that they saw workers on the
info/main/workers.htmlpage get into a bad state, turn red, and wished there was some way to be able to manually close workers that got into a bad state. This PR adds such a button (see attached screenshot)Note that this PR uses the scheduler API endpoint added in #6270. It's turned off by default (xref #6420) which significantly lowers the availability of these buttons (we only display the close buttons if this endpoint is explicitly enabled). I'm curious if folks have thoughts on a better mechanism to use that's always available, or if turning the scheduler API on by default makes sense.