Support pynvml>=11.5 in WSL #8962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 29 files ±0 29 suites ±0 12h 19m 25s ⏱️ - 9m 40s For more details on these failures, see this check. Results for commit b004b1f. ± Comparison against base commit 6eabc90. |
jakirkham
reviewed
Dec 11, 2024
Member
jakirkham
left a comment
jakirkham
left a comment
There was a problem hiding this comment.
Thanks Rick! 🙏
Had a simplifying suggestion below
jrbourbeau
reviewed
Dec 11, 2024
Member
jrbourbeau
left a comment
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @rjzamora @jakirkham @jacobtomlinson
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8961
Handles the case that
pynvml.nvmlSystemGetDriverVersion()returnsstrinstead ofbytes.