Skip to content

Remove protocol="ucx" support in favor of distributed-ucxx #9105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacobtomlinson merged 3 commits into from
Sep 4, 2025
Merged

Remove protocol="ucx" support in favor of distributed-ucxx #9105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63cc966
Remove UCX comm and tests
pentschev Sep 1, 2025
f5102db
Raise deprecation exception
pentschev Sep 3, 2025
52a17b3
Improve warning/error message
pentschev Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions distributed/comm/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,14 @@ def _register_transports():
backends["tls"] = tcp.TLSBackend()

try:
from distributed.comm import ucx
# If `distributed-ucxx` is installed, it takes over the protocol="ucx" support
import distributed_ucxx
except ImportError:
pass
try:
# Else protocol="ucx" will raise a deprecation warning and exception
from distributed.comm import ucx
except ImportError:
pass


_register_transports()
11 changes: 0 additions & 11 deletions distributed/comm/tests/test_comms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,16 +570,6 @@ async def client_communicate(key, delay=0):
listener.stop()


@pytest.mark.gpu
@gen_test()
async def test_ucx_client_server(ucx_loop):
pytest.importorskip("distributed.comm.ucx")
ucp = pytest.importorskip("ucp")

addr = ucp.get_address()
await check_client_server("ucx://" + addr)


def tcp_eq(expected_host, expected_port=None):
def checker(loc):
host, port = parse_host_port(loc)
Expand Down Expand Up @@ -1395,7 +1385,6 @@ async def test_do_not_share_buffers(tcp, list_cls):
See Also
--------
test_share_buffer_with_header
test_ucx.py::test_do_not_share_buffers
"""
np = pytest.importorskip("numpy")

Expand Down
Loading
Loading