Skip to content

Avoid deprecated is_datetime64tz_dtype from pandas#67

Merged
jrbourbeau merged 1 commit intodask:mainfrom
jrbourbeau:is_datetime64tz_dtype
Apr 17, 2023
Merged

Avoid deprecated is_datetime64tz_dtype from pandas#67
jrbourbeau merged 1 commit intodask:mainfrom
jrbourbeau:is_datetime64tz_dtype

Conversation

@jrbourbeau
Copy link
Copy Markdown
Member

@jrbourbeau jrbourbeau commented Apr 17, 2023

Currently the test suite gives

partd/tests/test_pandas.py: 17 warnings
  /Users/james/projects/dask/partd/partd/pandas.py:141: FutureWarning: is_datetime64tz_dtype is deprecated and will be removed in a future version. Check `isinstance(dtype, pd.DatetimeTZDtype)` instead.
    elif is_datetime64tz_dtype(block):

when run against the latest nightly pandas wheel due to is_datetime64tz_dtype being deprecated upstream. It's now recommended to just do a isinstance(..., pd.DatetimeTZDtype) check instead

xref pandas-dev/pandas#52607

cc @j-bennet @phofl

@jrbourbeau jrbourbeau merged commit 9db50c1 into dask:main Apr 17, 2023
@jrbourbeau jrbourbeau deleted the is_datetime64tz_dtype branch April 17, 2023 21:31
@j-bennet j-bennet mentioned this pull request Jul 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@phofl phofl phofl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jrbourbeau @phofl